I think it's true that the Res stored in a Path can only ever be a Res::Def; otherwise it won't have a path.

I see some places where it's a Res::Local instead, but rustdoc doesn't look at function bodies, so those won't show up.

@bors r+ rollup=iffy

📌 Commit 0965a33 has been approved by jyn514

It is now in the queue for this repository.

I think it's true that the Res stored in a Path can only ever be a Res::Def; otherwise it won't have a path.

That's not true, a Path can contain Res::Local, Res::Err, Res::PrimTy, Res::SelfTy. This patch works because of other constraints, e.g. one of the following.

• The Res comes from a trait definition, which seems to always be Res::Def.
• A Res::Def is constructed right at the register_res call site.
• The Res comes from a type definition, and the Res::PrimTy and Res::SelfTy variants are handled separately, as is the Res::Def(DefKind::TyParam, _) case.

⌛ Testing commit 0965a33 with merge c3f5929...

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing c3f5929 to master...

Finished benchmarking commit (c3f5929): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

Max RSS (memory usage)

Cycles